linux-kernel - Re: Subject: [PATCH] tty ldisc: Close/Reopen race prevention should check the proper flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120706212430.GA454@kroah.com>
Date:	Fri, 6 Jul 2012 14:24:30 -0700
From:	Greg KH <greg@...ah.com>
To:	Shachar Shemesh <shachar@...eu.tv>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Subject: [PATCH] tty ldisc: Close/Reopen race prevention should
 check the proper flag

On Sun, Jul 01, 2012 at 09:53:19AM +0300, Shachar Shemesh wrote:
> From: Shachar Shemesh <shachar@...eu.tv>
> 
> Commit acfa747b introduced the TTY_HUPPING flag to distinguish
> closed TTY from currently closing ones. The test in tty_set_ldisc
> still remained pointing at the old flag. This causes pppd to
> sometimes lapse into uninterruptible sleep when killed and
> restarted.
> 
> Signed-off-by: Shachar Shemesh <shachar@...eu.tv>
> ---
> Tested with 3.2.20 kernel.
> 
> diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
> index 24b95db..a662a24 100644
> --- a/drivers/tty/tty_ldisc.c
> +++ b/drivers/tty/tty_ldisc.c
> @@ -658,7 +658,7 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc)
>          goto enable;
>      }
> 
> -    if (test_bit(TTY_HUPPED, &tty->flags)) {
> +    if (test_bit(TTY_HUPPING, &tty->flags)) {

All tabs are converted to spaces and make this patch impossible to apply
:(

Care to try again?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/