linux-kernel - Re: [PATCH] x86: adjust generic_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQUNC2e03k=ECkQQU4732mGL-xidDyauAy0CdWjDg=EG8Q@mail.gmail.com>
Date:	Fri, 6 Jul 2012 14:38:50 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Jan Beulich <JBeulich@...e.com>
Cc:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: adjust generic_get_mtrr() for 64-bit

On Fri, Jul 6, 2012 at 7:14 AM, Jan Beulich <JBeulich@...e.com> wrote:
> Needing to deal with potentially large memory configurations, the
> variables here should be "unsigned long" instead of "unsigned int".
>
> Signed-off-by: Jan Beulich <jbeulich@...e.com>
>
> ---
>  arch/x86/kernel/cpu/mtrr/generic.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- 3.5-rc5/arch/x86/kernel/cpu/mtrr/generic.c
> +++ 3.5-rc5-x86-mtrr-generic-types/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -514,8 +514,8 @@ generic_get_free_region(unsigned long ba
>  static void generic_get_mtrr(unsigned int reg, unsigned long *base,
>                              unsigned long *size, mtrr_type *type)
>  {
> -       unsigned int mask_lo, mask_hi, base_lo, base_hi;
> -       unsigned int tmp, hi;
> +       unsigned long mask_lo, mask_hi, base_lo, base_hi, tmp;
> +       unsigned int hi;

_lo, _hi means we want it as 32bit.

or we just change them to u32 to make it more clear ?

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/