linux-kernel - Re: [PATCH 5/5] Staging: comedi: usbduxsigma: Syntax issue fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120706225532.GE10471@kroah.com>
Date:	Fri, 6 Jul 2012 15:55:32 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sebastian Benvenuti <sebastianbenvenuti@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Staging: comedi: usbduxsigma: Syntax issue fixes

On Thu, Jun 28, 2012 at 02:01:00AM -0300, Sebastian Benvenuti wrote:
> fixed "many quoted string split across lines" issues,
> replaced "printk(KERN_ERR" for "pr_err("
> and replaced "printk(KERN_INFO" for "pr_info("
> 
> Signed-off-by: Sebastian Benvenuti <sebastianbenvenuti@...il.com>

Where was...

Ok, you get the idea now.

Please fix up your patch numbering and resend these properly, in a
format that makes sense (hint, your current numbering made no sense...)

Also, stop doing:

>  			      this_usbduxsub->dux_commands, SIZEOFDUXBUFFER,
>  			      &nsent, BULK_TIMEOUT);
>  	if (result < 0)
> -		dev_err(&this_usbduxsub->interface->dev, "comedi%d: "
> -			"could not transmit dux_command to the usb-device, "
> +		dev_err(&this_usbduxsub->interface->dev, "comedi%d: " \
> +			"could not transmit dux_command to the usb-device, " \
>  			"err=%d\n", this_usbduxsub->comedidev->minor, result);

The '\' stuff is pointless and wrong.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/