linux-kernel - Re: [PATCH] mm/memcg: swappiness should between 0 and 100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120706050820.GB5929@kernel>
Date:	Fri, 6 Jul 2012 13:08:20 +0800
From:	Wanpeng Li <liwp.linux@...il.com>
To:	Gavin Shan <shangw@...ux.vnet.ibm.com>
Cc:	Wanpeng Li <liwp.linux@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...e.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	cgroups@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memcg: swappiness should between 0 and 100

On Fri, Jul 06, 2012 at 01:04:30PM +0800, Gavin Shan wrote:
>On Fri, Jul 06, 2012 at 01:00:13PM +0800, Gavin Shan wrote:
>>On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote:
>>>From: Wanpeng Li <liwp@...ux.vnet.ibm.com>
>>>
>>>Signed-off-by: Wanpeng Li <liwp.linux@...il.com>
>>>---
>>> mm/memcontrol.c |    2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>>diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>>>index 5e4d1ab..69a7d45 100644
>>>--- a/mm/memcontrol.c
>>>+++ b/mm/memcontrol.c
>>>@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft,
>>
>>It seems that we don't have the function in mainline.
>>
>>shangw@...ngw:~/sandbox/linux/mm$ grep mem_cgroup_swappiness_write -r .
>>shangw@...ngw:~/sandbox/linux/mm$ 
>>
>
>Please ignore that cause my git tree has some problems and everything
>in linux/mm has been cleared :-)

No problem. :-)

Best Regards,
Wanpeng Li

>
>Thanks,
>Gavin
>
>>Thanks,
>>Gavin
>>
>>> 	struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp);
>>> 	struct mem_cgroup *parent;
>>>
>>>-	if (val > 100)
>>>+	if (val > 100 || val < 0)
>>> 		return -EINVAL;
>>>
>>> 	if (cgrp->parent == NULL)
>>>-- 
>>>1.7.5.4
>>>
>>>--
>>>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>>>the body to majordomo@...ck.org.  For more info on Linux MM,
>>>see: http://www.linux-mm.org/ .
>>>Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>>>
>>
>>--
>>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>>the body to majordomo@...ck.org.  For more info on Linux MM,
>>see: http://www.linux-mm.org/ .
>>Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/