linux-kernel - Re: [Resend PATCH] media: rc: ati_remote.c: code style and compile warning fixing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 07 Jul 2012 00:09:01 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Du Changbin <changbin.du@...il.com>
CC:	mchehab@...radead.org, anssi.hannula@....fi,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Resend PATCH] media: rc: ati_remote.c: code style and compile
 warning fixing

Em 06-07-2012 22:49, Du Changbin escreveu:
>>> diff --git a/drivers/media/rc/ati_remote.c
> b/drivers/media/rc/ati_remote.c
>>> index 7be377f..0df66ac 100644
>>> --- a/drivers/media/rc/ati_remote.c
>>> +++ b/drivers/media/rc/ati_remote.c
>>> @@ -23,6 +23,8 @@
>>>     *                Vincent Vanackere <vanackere@....univ-mrs.fr>
>>>     *            Added support for the "Lola" remote contributed by:
>>>     *                Seth Cohn <sethcohn@...oo.com>
>>> + *  Jul 2012: Du, Changbin <changbin.du@...il.com>
>>> + *            Code style and compile warning fixing
>>
>> You shouldn't be changing the driver's authorship just due to codingstyle
>> and warning fixes. Btw, Please split Coding Style form Compilation
> warnings,
>> as they're two different matters.
> 
> Sorry, I didn't know this rule. I just want to make  a track for me. OK, I
> will resend this patch and remove me from it.
> BTW, I am looking for something to learn these basic rules when sending
> patches. Could you tell me where I can find it?

There are some rules at linuxtv wiki pages, others at the Kernel Documentation
dir and other not so explicit rules like the above that you'll get as you
continue contributing ;)

In opposite to other open source projects, the contribution history is the
git logs, and not inside the comments at the source code.


> Many thanks!
> [Du, Changbin]

Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/