linux-kernel - Re: [PATCH v2 05/11] fblog: register one fblog object per framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341785628.13174.28.camel@joe2Laptop>
Date:	Sun, 08 Jul 2012 15:13:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Herrmann <dh.herrmann@...glemail.com>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	florianschandinat@....de, linux-fbdev@...r.kernel.org,
	gregkh@...uxfoundation.org, alan@...rguk.ukuu.org.uk,
	bonbons@...ux-vserver.org
Subject: Re: [PATCH v2 05/11] fblog: register one fblog object per
 framebuffer

On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote:
>

Hi David.  Trivial comments only:

> diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c
[]
> @@ -23,15 +23,204 @@
>   * all fblog instances before running other graphics applications.
>   */

Please add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include and...

>  static int __init fblog_init(void)
>  {
> +	int ret;
> +
> +	ret = fb_register_client(&fblog_notifier);
> +	if (ret) {
> +		pr_err("fblog: cannot register framebuffer notifier");

Missing newline, pr_fmt would add module name.

		pr_err("cannot register framebuffer notifier\n");



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/