linux-kernel - Re: [PATCH 3/3] staging: vt6656: iwctl: remove a few remaining redundant newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1207090113590.15263@swampdragon.chaosbits.net>
Date:	Mon, 9 Jul 2012 01:16:15 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Joe Perches <joe@...ches.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Marcos Paulo de Souza <marcos.mage@...il.com>,
	Forest Bond <forest@...ttletooquiet.net>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: vt6656: iwctl: remove a few remaining
 redundant newlines

On Sun, 8 Jul 2012, Joe Perches wrote:

> On Mon, 2012-07-09 at 00:59 +0200, Jesper Juhl wrote:
> > I missed a few redundant newlines the first time.
> []
> > diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
> []
> > @@ -964,7 +964,6 @@ int iwctl_giwrts(struct net_device *dev, struct iw_request_info *info,
> >  	wrq->value = pDevice->wRTSThreshold;
> >  	wrq->disabled = (wrq->value >= 2312);
> >  	wrq->fixed = 1;
> > -
> >  	return 0;
> >  }
> 
> I think this is a useful style and these should not be removed.
> It's akin to a blank line after automatic variable declarations.
> 
Thank you for your feedback Joe.

I see your point, but personally I'd rather leave it out - especially for 
small functions.

I'll leave it up to Greg whether or not to take this one :-)


-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/