lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 08 Jul 2012 10:36:25 +0200 From: Jan Ceuleers <jan.ceuleers@...puter.org> To: Toshiaki Yamane <yamanetoshi@...il.com> CC: greg@...ah.com, sjakub@...il.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Fix checkpatch.pl issue. On 07/08/2012 10:16 AM, Toshiaki Yamane wrote: > -printk(KERN_ERR, to pr_err(... > > Signed-off-by: Toshiaki Yamane <yamanetoshi@...il.com> Hi I submit that your subject line should be more descriptive. Perhaps something like the following: [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...) The rest of your commit message could then clarify that this change was inspired by checkpatch. HTH, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists