linux-kernel - Re: [PATCH] synaptics_usb: Remove TrackPoint name trailing whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120708005220.GB19007@core.coreip.homeip.net>
Date:	Sat, 7 Jul 2012 17:52:20 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Bob Ross <pigiron@....com>
Cc:	Jan Steinhoff <mail@...-steinhoff.de>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] synaptics_usb: Remove TrackPoint name trailing whitespace

On Fri, Jul 06, 2012 at 12:28:17PM -0500, Bob Ross wrote:
> 
> The USB TrackPoint name string contains a space at the trailing end that
> can cause confusion/difficulty when creating udev rules. Example:
> 
>  "Synaptics Inc. Composite TouchPad / TrackPoint (Stick) "
> 
> This patch removes the trailing space.
> 
> Signed-off-by: Bob Ross <pigiron@....com>

Applied, thank you Bob.

> ---
> This patch was based from the "torvalds" git tree.
> 
>  drivers/input/mouse/synaptics_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/synaptics_usb.c b/drivers/input/mouse/synaptics_usb.c
> index 3c5eaaa..64cf34e 100644
> --- a/drivers/input/mouse/synaptics_usb.c
> +++ b/drivers/input/mouse/synaptics_usb.c
> @@ -364,7 +364,7 @@ static int synusb_probe(struct usb_interface *intf,
>  			 le16_to_cpu(udev->descriptor.idProduct));
>  
>  	if (synusb->flags & SYNUSB_STICK)
> -		strlcat(synusb->name, " (Stick) ", sizeof(synusb->name));
> +		strlcat(synusb->name, " (Stick)", sizeof(synusb->name));
>  
>  	usb_make_path(udev, synusb->phys, sizeof(synusb->phys));
>  	strlcat(synusb->phys, "/input0", sizeof(synusb->phys));
> -- 
> 1.7.11
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/