[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120709091517.GC2901@gmail.com>
Date: Mon, 9 Jul 2012 11:15:17 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Paul Turner <pjt@...gle.com>, linux-kernel@...r.kernel.org,
Venki Pallipadi <venki@...gle.com>,
Srivatsa Vaddagiri <vatsa@...ibm.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Nikunj A Dadhania <nikunj@...ux.vnet.ibm.com>,
Mike Galbraith <efault@....de>,
Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
Ben Segall <bsegall@...gle.com>, Ingo Molnar <mingo@...e.hu>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
Morten Rasmussen <Morten.Rasmussen@....com>,
Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>
Subject: Re: [PATCH 03/16] sched: aggregate load contributed by task entities
on parenting cfs_rq
* Peter Zijlstra <peterz@...radead.org> wrote:
> On Wed, 2012-07-04 at 17:28 +0200, Peter Zijlstra wrote:
> > On Wed, 2012-06-27 at 19:24 -0700, Paul Turner wrote:
> > > For a given task t, we can compute its contribution to load as:
> > > task_load(t) = runnable_avg(t) * weight(t)
> > >
> > > On a parenting cfs_rq we can then aggregate
> > > runnable_load(cfs_rq) = \Sum task_load(t), for all runnable children t
> > >
> > > Maintain this bottom up, with task entities adding their contributed load to
> > > the parenting cfs_rq sum. When a task entities load changes we add the same
> > > delta to the maintained sum.
> > >
> > > Signed-off-by: Paul Turner <pjt@...gle.com>
> > > Signed-off-by: Ben Segall <bsegall@...gle.com>
> >
> > A lot of patches have this funny sob trail.. Ben never send me these
> > patches, so uhm. ?
> >
> > Should that be Reviewed-by, or what is the deal with those?
>
> Ben could you clarify what your exact contribution was?
>
> Ingo, supposing Ben is co-author and wrote a significant part
> of the patch, what are we supposed to do with these tags?
There can be only one author SOB - additional contributions
should be reflected via credits in the changelog, copyright
lines and/or Originally-From: tags, or so.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists