linux-kernel - Re: [PATCH] sdio: Change pr_warning to pr_warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mx39ut0f.fsf@octavius.laptop.org>
Date:	Mon, 09 Jul 2012 06:29:52 -0400
From:	Chris Ball <cjb@...top.org>
To:	"Liu\, Chuansheng" <chuansheng.liu@...el.com>
Cc:	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mmc\@vger.kernel.org" <linux-mmc@...r.kernel.org>,
	"Yanmin Zhang \<yanmin_zhang\@linux.intel.com\>
	\(yanmin_zhang\@linux.intel.com\)" <yanmin_zhang@...ux.intel.com>
Subject: Re: [PATCH] sdio: Change pr_warning to pr_warn_ratelimited

Hi,

On Thu, Jun 14 2012, Liu, Chuansheng wrote:
> From: liu chuansheng <chuansheng.liu@...el.com>
> Subject: [PATCH] sdio: Change pr_warning to pr_warn_ratelimited
>
> When debug one bad issue, got lots of pr_warning messages
> "queuing unknown CIS tuple" which caused the printk storm
> and flooded the console.
>
> This patch is changing the pr_warning api to pr_warn_ratelimited.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>
> ---
>  drivers/mmc/core/sdio_cis.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
> index f1c7ed8..8e94e55 100644
> --- a/drivers/mmc/core/sdio_cis.c
> +++ b/drivers/mmc/core/sdio_cis.c
> @@ -313,7 +313,7 @@ static int sdio_read_cis(struct mmc_card *card, struct sdio_func *func)
>  
>                         if (ret == -ENOENT) {
>                                 /* warn about unknown tuples */
> -                               pr_warning("%s: queuing unknown"
> +                               pr_warn_ratelimited("%s: queuing unknown"
>                                        " CIS tuple 0x%02x (%u bytes)\n",
>                                        mmc_hostname(card->host),
>                                        tpl_code, tpl_link);

Thanks, pushed to mmc-next for 3.6.

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/