linux-kernel - Re: [PATCH] mm/hugetlb: split out is_hugetlb_entry_migration_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1207090343110.8224@chino.kir.corp.google.com>
Date:	Mon, 9 Jul 2012 03:43:48 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Wanpeng Li <liwp.linux@...il.com>
cc:	linux-mm@...ck.org, Michal Hocko <mhocko@...e.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Mel Gorman <mel@....ul.ie>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/hugetlb: split out
 is_hugetlb_entry_migration_or_hwpoison

On Mon, 9 Jul 2012, Wanpeng Li wrote:

> From: Wanpeng Li <liwp@...ux.vnet.ibm.com>
> 
> Code was duplicated in two functions, clean it up.
> 
> Signed-off-by: Wanpeng Li <liwp.linux@...il.com>
> ---
>  mm/hugetlb.c |   20 +++++++++-----------
>  1 files changed, 9 insertions(+), 11 deletions(-)

Nack, this makes the code more convoluted then the hugetlb code already is 
and savings two lines of code isn't worth it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/