linux-kernel - Re: [PATCH] Input: hid-input: Add suport for the brightness control keys on HP keyboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1207091626090.19366@pobox.suse.cz>
Date:	Mon, 9 Jul 2012 16:27:16 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Keng-Yu Lin <kengyu@...onical.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: hid-input: Add suport for the brightness control
 keys on HP keyboards

On Fri, 6 Jul 2012, Keng-Yu Lin wrote:

> The keys are found on the keyboards bundled with HP All-In-One machines
> with USB VID/PID of 04ca:004d and 04f2:1061.
> 
> Signed-off-by: Keng-Yu Lin <kengyu@...onical.com>
> ---
>  drivers/hid/hid-input.c |    9 +++++++++
>  include/linux/hid.h     |    1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index f333139..ecb8e48 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -648,6 +648,15 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  		}
>  		break;
>  
> +	case HID_UP_HPVENDOR2:
> +		set_bit(EV_REP, input->evbit);
> +		switch (usage->hid & HID_USAGE) {
> +		case 0x003: map_key_clear(KEY_BRIGHTNESSDOWN);	break;
> +		case 0x004: map_key_clear(KEY_BRIGHTNESSUP);	break;
> +		default:    goto ignore;
> +		}
> +		break;
> +
>  	case HID_UP_MSVENDOR:
>  		goto ignore;
>  
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index c235e4e..4365959 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -198,6 +198,7 @@ struct hid_item {
>  #define HID_UP_DIGITIZER	0x000d0000
>  #define HID_UP_PID		0x000f0000
>  #define HID_UP_HPVENDOR         0xff7f0000
> +#define HID_UP_HPVENDOR2        0xff010000

Let's hope these vendor-specific usage pages don't start out-of-control 
spreading.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/