linux-kernel - Re: [PATCH v2 04/11] fbdev: export get_fb_info()/put_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Jul 2012 19:34:44 +0200
From:	David Herrmann <dh.herrmann@...glemail.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	florianschandinat@....de, linux-fbdev@...r.kernel.org,
	gregkh@...uxfoundation.org, alan@...rguk.ukuu.org.uk,
	bonbons@...ux-vserver.org
Subject: Re: [PATCH v2 04/11] fbdev: export get_fb_info()/put_fb_info()

Hi Geert

On Mon, Jul 9, 2012 at 9:34 AM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Sun, Jul 8, 2012 at 11:56 PM, David Herrmann
> <dh.herrmann@...glemail.com> wrote:
>> --- a/drivers/video/fbmem.c
>> +++ b/drivers/video/fbmem.c
>> @@ -46,7 +46,7 @@ static DEFINE_MUTEX(registration_lock);
>>  struct fb_info *registered_fb[FB_MAX] __read_mostly;
>>  int num_registered_fb __read_mostly;
>>
>> -static struct fb_info *get_fb_info(unsigned int idx)
>> +struct fb_info *get_fb_info(unsigned int idx)
>>  {
>>         struct fb_info *fb_info;
>>
>> @@ -61,14 +61,16 @@ static struct fb_info *get_fb_info(unsigned int idx)
>>
>>         return fb_info;
>>  }
>> +EXPORT_SYMBOL(get_fb_info);
>
> EXPORT_SYMBOL_GPL?

Thanks, that seems more appropriate here. I've fixed it.

>> -static void put_fb_info(struct fb_info *fb_info)
>> +void put_fb_info(struct fb_info *fb_info)
>>  {
>>         if (!atomic_dec_and_test(&fb_info->count))
>>                 return;
>>         if (fb_info->fbops->fb_destroy)
>>                 fb_info->fbops->fb_destroy(fb_info);
>>  }
>> +EXPORT_SYMBOL(put_fb_info);
>
> EXPORT_SYMBOL_GPL?

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/