linux-kernel - Re: [PATCH 03/19 v2] Staging: xgifb: Remove LCDA detection in xgifb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120709183947.GA21153@kroah.com>
Date:	Mon, 9 Jul 2012 11:39:47 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Miguel Gómez <magomez@...lia.com>
Cc:	arnaud.patard@...-net.org, aaro.koskinen@....fi,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/19 v2] Staging: xgifb: Remove LCDA detection in
 xgifb_probe().

On Fri, Jul 06, 2012 at 12:40:38PM +0200, Miguel Gómez wrote:
> The piece of code that checks for LCDA in xgifb_probe() just checks for some
> register values but doesn't really do anything in response to them (the actions
> that should be executed are commented).
> As nothing is really being done, the code can be safely removed.

Are you sure?  Some devices (foolish ones that is) need registers read
to work properly as that is part of their start-up logic.  Yeah, it
doesn't seem to make sense, but hardware designers usually have good
reasons for doing this type of thing.  Or at least they think they do :)

So have you tested the device after this change and it all works
properly?  You do have this device, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/