linux-kernel - Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120709200604.GA2536@kroah.com>
Date:	Mon, 9 Jul 2012 13:06:04 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Devendra Naga <devendra.aaru@...il.com>
Cc:	Lior Dotan <liodot@...il.com>,
	Christopher Harrer <charrer@...critech.com>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

On Mon, Jul 09, 2012 at 11:04:19PM +0530, Devendra Naga wrote:
> at probe we enabled the device, and we should disable it at remove.
> 
> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
> ---
>  drivers/staging/slicoss/slicoss.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index a511a2b..5bd3825 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -3234,6 +3234,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
>  	}
>  	free_netdev(dev);
>  	pci_release_regions(pcidev);
> +	pci_disable_device(pcidev);

No, you really shouldn't do this, see the many times this has come up on
the linux-kernel mailing list for why.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/