linux-kernel - Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Jul 2012 22:34:37 +0200
From:	Lee Jones <lee.jones@...aro.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de
Subject: Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

> Why do you keep these assignments and then override them with
> translations? Why don't you do
>
> 	ponkey->idev = input;
> 	ponkey->ab8500 = ab8500;
> 	ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> 	ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
>
> to begin with?

Ah, I see what you mean now.

Sorry, just glossed over your first email.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/