linux-kernel - Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Jul 2012 22:56:49 +0200
From:	Lee Jones <lee.jones@...aro.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de
Subject: Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

On 09/07/12 22:46, Dmitry Torokhov wrote:
> On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote:
>> From: Lee Jones <lee.jones@...aro.org>
>> Date: Tue, 26 Jun 2012 10:46:50 +0100
>> Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping
>>
>> Before we can use any domain allocated IRQ, we need to first create a
>> map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq).
>> We do this with a helper function provided by the AB8500 IRQ domain
>> controller called ab8500_irq_get_virq(). We need to do this for both
>> IRQs which the Power-On-Key driver uses; one for button press, the other
>> for button depress.
>>
>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
>> ---
>>   drivers/input/misc/ab8500-ponkey.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c
>> index 5ceb23e..8d24189 100644
>> --- a/drivers/input/misc/ab8500-ponkey.c
>> +++ b/drivers/input/misc/ab8500-ponkey.c
>> @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev)
>>
>>   	ponkey->idev = input;
>>   	ponkey->ab8500 = ab8500;
>> -	ponkey->irq_dbf = irq_dbf;
>> -	ponkey->irq_dbr = irq_dbr;
>> +	ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, ponkey->irq_dbf);
>> +	ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, ponkey->irq_dbr);
>                                                        ^^^^^^^^^^^^^^^
>
> These are zeroes now. Man, you are killing me...

I've been traveling all day and my brain is dead.

Hopefully you have a sense of humor. :)

Give me two mins.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/