linux-kernel - Re: [PATCH 0/6] staging: vt6655: Cleanup in usage of macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341807891.13174.40.camel@joe2Laptop>
Date:	Sun, 08 Jul 2012 21:24:51 -0700
From:	Joe Perches <joe@...ches.com>
To:	Marcos Paulo de Souza <marcos.souza.org@...il.com>
Cc:	gregkh@...uxfoundation.org, andriy.shevchenko@...ux.intel.com,
	jj@...osbits.net, forest@...ttletooquiet.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] staging: vt6655: Cleanup in usage of macros

On Sun, 2012-07-08 at 23:51 -0300, Marcos Paulo de Souza wrote:
> Hi kernel guys!
> 
> This patchset aims to clean all unused and commented macros.
> 
> For this challenge, forgotten-macros tool helped us.

Perhaps there may be false positives in your code.

Many times, macros like the below are used:

#define SUBSYSTEM_PREFIX_FOO	1
#define SUBSYSTEM_PREFIX_BAR	2
#define SUBSYSTEM_PREFIX_BAZ	3

#define USE_TYPE(type)	SUBSYSTEM_PREFIX_##type

It doesn't seem your code knows that style.

Also, the tool might be more flexible if it was
written using perl or python.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/