linux-kernel - Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120710061757.GB29257@core.coreip.homeip.net>
Date:	Mon, 9 Jul 2012 23:17:57 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de
Subject: Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ
 mapping

On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote:
> Sorry for the cock-up(s).
> 
> From: Lee Jones <lee.jones@...aro.org>
> Date: Tue, 26 Jun 2012 10:46:50 +0100
> Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping
> 
> Before we can use any domain allocated IRQ, we need to first create a
> map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq).
> We do this with a helper function provided by the AB8500 IRQ domain
> controller called ab8500_irq_get_virq(). We need to do this for both
> IRQs which the Power-On-Key driver uses; one for button press, the other
> for button depress.
> 
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

I think it would be best if this got merged through whatever tree that
was used to introduce ab8500_irq_get_virq(); otherwise it will have to
wait till I resync with mainline sometime in the middle of the next
release cycle.

Thanks.

> ---
>  drivers/input/misc/ab8500-ponkey.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c
> index 5ceb23e..f6764af 100644
> --- a/drivers/input/misc/ab8500-ponkey.c
> +++ b/drivers/input/misc/ab8500-ponkey.c
> @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev)
>  
>  	ponkey->idev = input;
>  	ponkey->ab8500 = ab8500;
> -	ponkey->irq_dbf = irq_dbf;
> -	ponkey->irq_dbr = irq_dbr;
> +	ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> +	ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
>  
>  	input->name = "AB8500 POn(PowerOn) Key";
>  	input->dev.parent = &pdev->dev;
> -- 
> 1.7.9.5
> 
> 
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/