linux-kernel - Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAe_U6JE6XoNm85zcS6c=EbbXy=c0=gzTda6sChr8VSjNM+utw@mail.gmail.com>
Date:	Tue, 10 Jul 2012 12:25:13 +0530
From:	"ABRAHAM, KISHON VIJAY" <kishon@...com>
To:	Rajendra Nayak <rnayak@...com>
Cc:	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	rob@...dley.net, linux@....linux.org.uk,
	gregkh@...uxfoundation.org, b-cousson@...com, tony@...mide.com,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	balbi@...com, linux-omap@...r.kernel.org,
	linux-usb@...r.kernel.org, hvaibhav@...com
Subject: Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

Hi,

On Tue, Jul 10, 2012 at 11:43 AM, Rajendra Nayak <rnayak@...com> wrote:
> On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
>>
>> Add twl4030-usb data node in twl4030 device tree file.
>>
>> Signed-off-by: Kishon Vijay Abraham I<kishon@...com>
>> ---
>>   arch/arm/boot/dts/twl4030.dtsi |   21 +++++++++++++++++++++
>>   1 files changed, 21 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/twl4030.dtsi
>> b/arch/arm/boot/dts/twl4030.dtsi
>> index 22f4d13..66534a3 100644
>> --- a/arch/arm/boot/dts/twl4030.dtsi
>> +++ b/arch/arm/boot/dts/twl4030.dtsi
>> @@ -37,6 +37,18 @@
>>                 regulator-max-microvolt =<3150000>;
>>         };
>>
>> +       vusb1v5: regulator@3 {
>> +               compatible = "ti,twl4030-vusb1v5";
>> +       };
>
>
> These @3, @4 are actually wrong since the node do
> not have a 'reg' property in it. This was commented on
> by David Brown on my original series which added this but
> it somehow slipped through the cracks. I understand that
> you would have looked up what existed in the file and
> extended, but what already exists in the file needs to
> be fixed up too. I'll send in a patch to fix those up.

Ok. i'll follow suit :-)

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/