linux-kernel - Re: acpi: remove unused LIST_HEAD(acpi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH5vBdKbiZTL_o3tKKk55oyuzyufaeiSr1PgXKrUj6FgPmFMmw@mail.gmail.com>
Date:	Tue, 10 Jul 2012 00:40:16 -0700
From:	cheng renquan <crquan@...il.com>
To:	Len Brown <lenb@...nel.org>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: acpi: remove unused LIST_HEAD(acpi_device_list) && more static analysis

On Tue, Jul 10, 2012 at 12:00 AM, cheng renquan <crquan@...il.com> wrote:
> $ git diff HEAD -- drivers/acpi/scan.c
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 85cbfdc..7d26ae0 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -28,7 +28,7 @@ extern struct acpi_device *acpi_root;
>
>  static const char *dummy_hid = "device";
>
> -static LIST_HEAD(acpi_device_list);
>  static LIST_HEAD(acpi_bus_id_list);
>  DEFINE_MUTEX(acpi_device_lock);
>  LIST_HEAD(acpi_wakeup_device_list);

fortunately a later step of gcc optimization deleted that variable
so it doesn't consume space in the final vmlinux, only the really in-use
variable like the next acpi_bus_id_list consumed space;

$ eu-readelf -s drivers/acpi/scan.o |egrep '(acpi_device_list|acpi_bus_id_list)'
   35: 00000000000000b0     16 OBJECT  LOCAL  DEFAULT        3 acpi_bus_id_list

$ eu-readelf -s vmlinux |egrep '(acpi_device_list|acpi_bus_id_list)'
24029: ffffffff81a62bc0     16 OBJECT  LOCAL  DEFAULT       15 acpi_bus_id_list


anyway, we'd better to delete the acpi_device_list from the source;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/