linux-kernel - Re: [PATCH RFC 2/2] kvm PLE handler: Choose better candidate for directed yield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FFC1610.5060801@linux.vnet.ibm.com>
Date:	Tue, 10 Jul 2012 17:16:24 +0530
From:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
To:	Rik van Riel <riel@...hat.com>
CC:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Ingo Molnar <mingo@...hat.com>, Avi Kivity <avi@...hat.com>,
	S390 <linux-s390@...r.kernel.org>,
	Carsten Otte <cotte@...ibm.com>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	KVM <kvm@...r.kernel.org>, chegu vinod <chegu_vinod@...com>,
	"Andrew M. Theurer" <habanero@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>, X86 <x86@...nel.org>,
	Gleb Natapov <gleb@...hat.com>, linux390@...ibm.com,
	Srivatsa Vaddagiri <srivatsa.vaddagiri@...il.com>,
	Joerg Roedel <joerg.roedel@....com>
Subject: Re: [PATCH RFC 2/2] kvm PLE handler: Choose better candidate for
 directed yield

On 07/10/2012 04:00 AM, Rik van Riel wrote:
> On 07/09/2012 02:20 AM, Raghavendra K T wrote:
>
>> +bool kvm_arch_vcpu_check_and_update_eligible(struct kvm_vcpu *vcpu)
>> +{
>> + bool eligible;
>> +
>> + eligible = !vcpu->arch.plo.pause_loop_exited ||
>> + (vcpu->arch.plo.pause_loop_exited&&
>> + vcpu->arch.plo.dy_eligible);
>> +
>> + if (vcpu->arch.plo.pause_loop_exited)
>> + vcpu->arch.plo.dy_eligible = !vcpu->arch.plo.dy_eligible;
>> +
>> + return eligible;
>> +}
>
> This is a nice simple mechanism to skip CPUs that were
> eligible last time and had pause loop exits recently.
>
> However, it could stand some documentation. Please
> add a good comment explaining how and why the algorithm
> works, when arch.plo.pause_loop_exited is cleared, etc...
>
> It would be good to make this heuristic understandable
> to people who look at the code for the first time.
>

Thanks for the review. will do more documentation.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/