linux-kernel - Re: bisected regression since 3.5-rc5 - hang on boot on some sparc64 machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FFC4399.3050407@calxeda.com>
Date:	Tue, 10 Jul 2012 10:00:41 -0500
From:	Rob Herring <rob.herring@...xeda.com>
To:	Meelis Roos <mroos@...ux.ee>,
	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Thierry Reding <thierry.reding@...onic-design.de>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	sparclinux@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org
Subject: Re: bisected regression since 3.5-rc5 - hang on boot on some sparc64
 machines

On 07/10/2012 06:09 AM, Meelis Roos wrote:
> A regression since 3.5-rc5 stops Sun Fire V100 and Sun Netra X1 sparc64 
> machines from booting, hanging after enabling serial console. Several 
> different other sparc64 systems work fine with 3.5-rc6. prtconf and full 
> dmesg below.
> 
> Bisecting leads to
> 107a84e61cdd3406c842a0e4be7efffd3a05dba6 is the first bad commit
> commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6
> Author: Thierry Reding <thierry.reding@...onic-design.de>
> Date:   Thu Jun 14 09:12:35 2012 +0200
> 
>     of: match by compatible property first
>     
>     When matching devices against an OF device ID table, the first string of
>     the compatible property that is listed in the table should match,
>     regardless of its position in the table.
>     
>     Cc: Grant Likely <grant.likely@...retlab.ca>
>     Cc: Rob Herring <rob.herring@...xeda.com>
>     Cc: devicetree-discuss@...ts.ozlabs.org
>     Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
>     Signed-off-by: Rob Herring <rob.herring@...xeda.com>

The problem is match combinations of compatible plus name and/or type
fail to match correctly. I have a fix for this, but given how late it is
for 3.5 I think it is best to revert this for now. There could be other
cases that rely on the current although wrong behavior. I will post an
updated version for 3.6.

Linus, Please revert 107a84e61cdd3406c842a0e4be7efffd3a05dba6.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/