[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAErSpo7zftEkExQMND_a7V-nJKqvuncNGnC_rfFtxQfywUO4jA@mail.gmail.com>
Date: Tue, 10 Jul 2012 12:44:39 -0600
From: Bjorn Helgaas <bhelgaas@...gle.com>
To: Jiang Liu <liuj97@...il.com>
Cc: Don Dutile <ddutile@...hat.com>, Yinghai Lu <yinghai@...nel.org>,
Taku Izumi <izumi.taku@...fujitsu.com>,
"Rafael J . Wysocki" <rjw@...k.pl>,
Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
Yijing Wang <wangyijing@...wei.com>,
Keping Chen <chenkeping@...wei.com>,
linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [RFC PATCH 00/14] improve PCIe capabilities registers handling
On Tue, Jul 10, 2012 at 9:54 AM, Jiang Liu <liuj97@...il.com> wrote:
> From: Jiang Liu <liuj97@...il.com>
>
> As suggested by Bjorn Helgaas and Don Dutile in threads
> http://www.spinics.net/lists/linux-pci/msg15663.html, we could improve access
> to PCIe capabilities register in to way:
> 1) cache content of PCIe Capabilities Register into struct pce_dev to avoid
> repeatedly reading this register because it's read only.
> 2) provide access functions for PCIe Capabilities registers to hide differences
> among PCIe base specifications, so the caller don't need to handle those
> differences.
>
> This patch set applies to
> git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci-next
>
> These patch set is still RFC. It provides the new interfaces and has made the
> major changes to adopt those new interfaces. But there are still several device
> drivers left untouched. Any comments about the new interfaces are welcomed,
> especially about function names:). Once we reach an agreement, I will send out
> a formal version with all needed work done.
>
> Jiang Liu (11):
> PCI: refine and move pcie_cap_has_*() macros to include/linux/pci.h
> PCI: add access functions for PCIe capabilities to hide PCIe spec
> differences
> PCI: use PCIe cap access functions to simplify PCI core
> implementation
> hotplug/PCI: use PCIe cap access functions to simplify implementation
> portdrv/PCI: use PCIe cap access functions to simplify implementation
> pciehp/PCI: use PCIe cap access functions to simplify implementation
> PME/PCI: use PCIe cap access functions to simplify implementation
> AER/PCI: use PCIe cap access functions to simplify implementation
> ASPM/PCI: use PCIe cap access functions to simplify implementation
> r8169/PCI: use PCIe cap access functions to simplify implementation
> qib/PCI: use PCIe cap access functions to simplify implementation
>
> Yijing Wang (1):
> PCI: add pcie_flags into struct pci_dev to cache PCIe capabilities
> register
> PCI: introduce pci_pcie_type(dev) to replace pci_dev->pcie_type
> PCI: remove unused field pcie_type from struct pci_dev
>
> arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
> drivers/infiniband/hw/qib/qib_pcie.c | 34 ++-
> drivers/iommu/intel-iommu.c | 6 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
> .../net/ethernet/qlogic/netxen/netxen_nic_main.c | 2 +-
> drivers/net/ethernet/realtek/r8169.c | 38 +--
> drivers/pci/access.c | 88 +++++++
> drivers/pci/hotplug/pciehp_acpi.c | 5 +-
> drivers/pci/hotplug/pciehp_hpc.c | 8 +-
> drivers/pci/hotplug/pcihp_slot.c | 17 +-
> drivers/pci/iov.c | 6 +-
> drivers/pci/pci.c | 265 +++++---------------
> drivers/pci/pcie/aer/aer_inject.c | 2 +-
> drivers/pci/pcie/aer/aerdrv.c | 23 +-
> drivers/pci/pcie/aer/aerdrv_acpi.c | 2 +-
> drivers/pci/pcie/aer/aerdrv_core.c | 47 ++--
> drivers/pci/pcie/aspm.c | 110 ++++----
> drivers/pci/pcie/pme.c | 23 +-
> drivers/pci/pcie/portdrv_bus.c | 2 +-
> drivers/pci/pcie/portdrv_core.c | 24 +-
> drivers/pci/pcie/portdrv_pci.c | 15 +-
> drivers/pci/probe.c | 30 +--
> drivers/pci/quirks.c | 8 +-
> drivers/pci/search.c | 2 +-
> include/linux/pci.h | 65 ++++-
> include/linux/pci_regs.h | 19 +-
> 26 files changed, 401 insertions(+), 444 deletions(-)
Very nice; I like this a lot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists