| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Jul 2012 12:41:55 +0800
From: Fengguang Wu <fengguang.wu@...el.com>
To: Thomas Hellstrom <thellstrom@...are.com>
Cc: Dave Airlie <airlied@...hat.com>, dri-devel@...ts.freedesktop.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: general protection fault on ttm_init()
On Sat, Jul 07, 2012 at 11:31:42PM +0800, Fengguang Wu wrote:
> On Sat, Jul 07, 2012 at 10:08:47AM +0800, Fengguang Wu wrote:
> > On Fri, Jul 06, 2012 at 06:09:20PM +0100, Dave Airlie wrote:
> > > On Fri, Jul 6, 2012 at 5:49 PM, Dave Airlie <airlied@...il.com> wrote:
> > > > On Fri, Jul 6, 2012 at 3:48 PM, Fengguang Wu <fengguang.wu@...el.com> wrote:
> > > >> ... The missed kconfig.
> > > >>
> > > >> On Fri, Jul 06, 2012 at 10:46:22PM +0800, Fengguang Wu wrote:
> > > >>> Hi Thomas,
> > > >
> > > > Wierd, I'm sorta tempted to just depend drm on CONFIG_PROC_FS, but it
> > > > looks like the error path is failing to dtrt.
> > >
> > > I've attached a patch that should fix it, let me know if it works.
> >
> > It does not work.. The dmesg (attached) remains the same.
>
> I got more interesting back traces in a clean kernel:
Another trace shows that ttm_init tries to register with an empty name:
[ 2.919061] WARNING: at /c/kernel-tests/tip/lib/kobject.c:166 kobject_add_internal+0x1a3/0x210()
[ 2.917489] device: 'ttm': device_add
[ 2.918179] ------------[ cut here ]------------
[ 2.919061] WARNING: at /c/kernel-tests/tip/lib/kobject.c:166 kobject_add_internal+0x1a3/0x210()
==> [ 2.920704] kobject: (ffff88000026ecc0): attempted to be registered with empty name!
[ 2.922129] Pid: 1, comm: swapper Not tainted 3.5.0-rc2+ #28
[ 2.923172] Call Trace:
[ 2.923638] [<ffffffff8136fb53>] ? kobject_add_internal+0x1a3/0x210
[ 2.924827] [<ffffffff8103c316>] warn_slowpath_common+0x66/0x90
[ 2.925993] [<ffffffff822fa6b6>] ? drm_core_init+0xca/0xca
[ 2.927028] [<ffffffff8103c3b1>] warn_slowpath_fmt+0x41/0x50
[ 2.928093] [<ffffffff8136fb53>] kobject_add_internal+0x1a3/0x210
[ 2.929261] [<ffffffff822fa6b6>] ? drm_core_init+0xca/0xca
[ 2.930327] [<ffffffff822fa6b6>] ? drm_core_init+0xca/0xca
[ 2.931473] [<ffffffff8136fc27>] kobject_add+0x67/0xc0
[ 2.932589] [<ffffffff81d6c595>] ? get_device_parent+0x118/0x1b7
[ 2.933790] [<ffffffff81d6c5de>] get_device_parent+0x161/0x1b7
[ 2.934895] [<ffffffff81536461>] device_add+0x151/0x5f0
[ 2.935907] [<ffffffff822fa6b6>] ? drm_core_init+0xca/0xca
[ 2.936940] [<ffffffff8138c5f8>] ? __raw_spin_lock_init+0x38/0x70
[ 2.938099] [<ffffffff822fa6b6>] ? drm_core_init+0xca/0xca
[ 2.939132] [<ffffffff81536919>] device_register+0x19/0x20
[ 2.940254] [<ffffffff81460bb7>] drm_class_device_register+0x17/0x20
[ 2.941437] [<ffffffff822fa6ed>] ttm_init+0x37/0x62
[ 2.942360] [<ffffffff822d5c79>] do_one_initcall+0x78/0x136
[ 2.943413] [<ffffffff822d5e59>] kernel_init+0x122/0x1a6
[ 2.944415] [<ffffffff822d5567>] ? loglevel+0x31/0x31
[ 2.945402] [<ffffffff81d85e04>] kernel_thread_helper+0x4/0x10
[ 2.946506] [<ffffffff81d8472c>] ? retint_restore_args+0x13/0x13
[ 2.947635] [<ffffffff822d5d37>] ? do_one_initcall+0x136/0x136
[ 2.948739] [<ffffffff81d85e00>] ? gs_change+0x13/0x13
Thanks,
Fengguang
> device class 'drm': registering
> kobject: 'drm' (ffff88000f07f050): kobject_add_internal: parent: 'class', set: 'class'
> kobject: 'drm' (ffff88000f07f050): kobject_uevent_env
> kobject: 'drm' (ffff88000f07f050): fill_kobj_path: path = '/class/drm'
> [drm:drm_core_init] *ERROR* Cannot create /proc/dri
> device class 'drm': unregistering
> kobject: 'drm' (ffff88000f07f050): kobject_cleanup
> kobject: 'drm' (ffff88000f07f050): auto cleanup 'remove' event
> kobject: 'drm' (ffff88000f07f050): kobject_uevent_env
> kobject: 'drm' (ffff88000f07f050): fill_kobj_path: path = '/class/drm'
> kobject: 'drm' (ffff88000f07f050): auto cleanup kobject_del
> kobject: 'drm' (ffff88000f07f050): calling ktype release
> class 'drm': release.
> class_create_release called for drm
> kobject: 'drm': free name
> kobject: 'drm' (ffff88000f080070): kobject_cleanup
> kobject: 'drm' (ffff88000f080070): calling ktype release
> kobject: 'drm': free name
> device: 'ttm': device_add
> kobject: '(null)' (ffff88000f080230): kobject_add_internal: parent: 'virtual', set: '(null)'
> kobject: 'ttm' (ffffffff824709b0): kobject_add_internal: parent: '(null)', set: 'devices'
> general protection fault: 0000 [#1] SMP
> CPU 1
> Pid: 1, comm: swapper/0 Not tainted 3.5.0-rc5-bisect #207
> RIP: 0010:[<ffffffff8115eb59>] [<ffffffff8115eb59>] sysfs_do_create_link+0x59/0x1c0
> RSP: 0018:ffff880000107db0 EFLAGS: 00010206
> RAX: ffff880000100000 RBX: 00cccccccccccccc RCX: 000000000000dad9
> RDX: 000000000000d9d9 RSI: 0000000000000000 RDI: ffffffff8243b320
> RBP: ffff880000107e00 R08: ffff880000100580 R09: fffffffffe000080
> R10: ffff880000100000 R11: 0000000002000000 R12: ffffffff821622db
> R13: ffff88000f080150 R14: 0000000000000001 R15: ffff88000f080308
> FS: 0000000000000000(0000) GS:ffff88000df00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> CR2: 0000000000000000 CR3: 0000000002411000 CR4: 00000000000006a0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> Process swapper/0 (pid: 1, threadinfo ffff880000106000, task ffff880000100000)
> Stack:
> ffff88000f080308 0000000000000000 ffffffff824709b0 00000000000002ec
> 0000000000000000 0000000000000000 ffffffff824709b0 00000000000002ec
> 0000000000000000 ffffffff824709a0 ffff880000107e10 ffffffff8115ecce
> Call Trace:
> [<ffffffff8115ecce>] sysfs_create_link+0xe/0x10
> [<ffffffff81580309>] device_add+0x289/0x610
> [<ffffffff8255aae2>] ? drm_core_init+0xca/0xca
> [<ffffffff81589d09>] ? device_pm_init+0x69/0x90
> [<ffffffff8255aae2>] ? drm_core_init+0xca/0xca
> [<ffffffff815806a9>] device_register+0x19/0x20
> [<ffffffff8147d507>] drm_class_device_register+0x17/0x20
> [<ffffffff8255ab19>] ttm_init+0x37/0x62
> [<ffffffff8252ed56>] do_one_initcall+0x7a/0x139
> [<ffffffff8252ef18>] kernel_init+0x103/0x187
> [<ffffffff8252e614>] ? do_early_param+0x8c/0x8c
> [<ffffffff81ccf334>] kernel_thread_helper+0x4/0x10
> [<ffffffff81ccd8b0>] ? retint_restore_args+0x13/0x13
> [<ffffffff8252ee15>] ? do_one_initcall+0x139/0x139
> [<ffffffff81ccf330>] ? gs_change+0x13/0x13
> Code: 4c 8b 7f 30 bb f2 ff ff ff 4d 85 ff 0f 84 a2 00 00 00 48 c7 c7 20 b3 43 82 e8 c4 e2 b6 00 49 8b 5d 30 48 85 db 0f 84 27 01 00 00 <8b> 03 f0 ff 03 48 c7 c7 20 b3 43 82 e8 d6 e3 b6 00 4c 89 e7 ba
> RIP [<ffffffff8115eb59>] sysfs_do_create_link+0x59/0x1c0
> RSP <ffff880000107db0>
>
>
> and:
>
>
> kobject: 'drm': free name
> device: 'ttm': device_add
> BUG: unable to handle kernel paging request at 0000000100000001
> IP: [<ffffffff8137b7ad>] strnlen+0xd/0x40
> PGD 0
> Oops: 0000 [#1] SMP
> CPU 1
> Pid: 1, comm: swapper/0 Not tainted 3.5.0-rc5-bisect #207
> RIP: 0010:[<ffffffff8137b7ad>] [<ffffffff8137b7ad>] strnlen+0xd/0x40
> RSP: 0018:ffff880000107c30 EFLAGS: 00010286
> RAX: ffffffff8210a8fc RBX: 0000000000000000 RCX: fffffffffffffffe
> RDX: 0000000100000001 RSI: ffffffffffffffff RDI: 0000000100000001
> RBP: ffff880000107c30 R08: 000000000000ffff R09: 000000000000ffff
> R10: ffff88000f0750f0 R11: ffffffff824384e0 R12: 0000000100000001
> R13: 0000000000000000 R14: 000000000000ffff R15: 0000000000000000
> FS: 0000000000000000(0000) GS:ffff88000df00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> CR2: 0000000100000001 CR3: 0000000002411000 CR4: 00000000000006a0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> Process swapper/0 (pid: 1, threadinfo ffff880000106000, task ffff880000100000)
> Stack:
> ffff880000107c70 ffffffff8137cc3e ffffffff82ff88a0 0000000000000000
> 0000000000000000 ffff880000107d08 ffffffff8222f3dc ffffffff8222f3dc
> ffff880000107cf0 ffffffff8137d719 0000000000000007 0000000000000006
> Call Trace:
> [<ffffffff8137cc3e>] string.isra.4+0x3e/0xd0
> [<ffffffff8137d719>] vsnprintf+0x219/0x5e0
> [<ffffffff81381468>] kvasprintf+0x48/0x90
> [<ffffffff81374fa1>] kobject_set_name_vargs+0x21/0x60
> [<ffffffff81375394>] kobject_add+0x54/0xc0
> [<ffffffff81cb9093>] get_device_parent.isra.11+0x142/0x18f
> [<ffffffff815801b8>] device_add+0x138/0x610
> [<ffffffff8255aae2>] ? drm_core_init+0xca/0xca
> [<ffffffff81589d09>] ? device_pm_init+0x69/0x90
> [<ffffffff8255aae2>] ? drm_core_init+0xca/0xca
> [<ffffffff815806a9>] device_register+0x19/0x20
> [<ffffffff8147d507>] drm_class_device_register+0x17/0x20
> [<ffffffff8255ab19>] ttm_init+0x37/0x62
> [<ffffffff8252ed56>] do_one_initcall+0x7a/0x139
> [<ffffffff8252ef18>] kernel_init+0x103/0x187
> [<ffffffff8252e614>] ? do_early_param+0x8c/0x8c
> [<ffffffff81ccf334>] kernel_thread_helper+0x4/0x10
> [<ffffffff81ccd8b0>] ? retint_restore_args+0x13/0x13
> [<ffffffff8252ee15>] ? do_one_initcall+0x139/0x139
> [<ffffffff81ccf330>] ? gs_change+0x13/0x13
> Code: c0 01 80 38 00 75 f7 48 29 f8 5d c3 31 c0 5d c3 66 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 85 f6 48 8d 4e ff 48 89 e5 74 2a <80> 3f 00 74 25 48 89 f8 31 d2 eb 10 0f 1f 80 00 00 00 00 48 83
> RIP [<ffffffff8137b7ad>] strnlen+0xd/0x40
> RSP <ffff880000107c30>
> CR2: 0000000100000001
>
>
> Thanks,
> Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists