linux-kernel - Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHdPZaNvm8ag1=dCcwsdPJHTA9YxOV0vBZfOLSXy_vRfmXnQUA@mail.gmail.com>
Date:	Wed, 11 Jul 2012 10:48:57 +0545
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Lior Dotan <liodot@...il.com>,
	Christopher Harrer <charrer@...critech.com>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

On Wed, Jul 11, 2012 at 12:13 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>> I haven't see this?  Why don't you want to disable a device at remove
>> time?  Because we put the disable in the generic pci layer?
>
> For some reason, I thought we didn't do this because of other
> "interfaces" on the same card might then be shut down.  But I must have
> been thinking of something else, as lots of drivers do this, so adding
> it here looks to be correct.
>
> So, sorry Devendra, you were right, care to resend this so I can apply
> it?
>

Hi Greg,

I will send the patch out in few hrs, with V2 name.

Actually i was referring to the discussion here in this link,

https://lkml.org/lkml/2005/2/13/82

it says about if the request regions fails we do not disable the
device, as the other driver may be using the device.
since the remove function of the driver is calling, which means that
probe succeeded, so i think its fine to call
pci_disable_device at driver_remove.


> thanks,
>
> greg k-h

Thanks,
devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/