linux-kernel - Re: [PATCH 1/3] panel: Use pr_debug(...) rather than printk(KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341953917.6118.165.camel@joe2Laptop>
Date:	Tue, 10 Jul 2012 13:58:37 -0700
From:	Joe Perches <joe@...ches.com>
To:	Toshiaki Yamane <yamanetoshi@...il.com>
Cc:	greg@...ah.com, willy@...a-x.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] panel: Use pr_debug(...) rather than
 printk(KERN_DEBUG ...)

On Tue, 2012-07-10 at 20:22 +0900, Toshiaki Yamane wrote:
> This change is inspired by checkpatch.
[]
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
[]
> @@ -1838,9 +1838,8 @@ static void panel_process_inputs(void)
>  	struct logical_input *input;
>  
>  #if 0
> -	printk(KERN_DEBUG
> -	       "entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
> -	       phys_prev, phys_curr);
> +	pr_debug("entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
> +		 phys_prev, phys_curr);
>  #endif

Might as well delete these #if 0 blocks instead

>  
>  	keypressed = 0;
> @@ -2003,8 +2002,8 @@ static struct logical_input *panel_bind_key(char *name, char *press,
>  	key->fall_time = 1;
>  
>  #if 0
> -	printk(KERN_DEBUG "bind: <%s> : m=%016Lx v=%016Lx\n", name, key->mask,
> -	       key->value);
> +	pr_debug("bind: <%s> : m=%016Lx v=%016Lx\n", name, key->mask,
> +		 key->value);
>  #endif
>  	strncpy(key->u.kbd.press_str, press, sizeof(key->u.kbd.press_str));
>  	strncpy(key->u.kbd.repeat_str, repeat, sizeof(key->u.kbd.repeat_str));




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/