linux-kernel - Re: [PATCH] usb/host/ehci-hub: Fix the issue EG20T USB host controller has long resuming time, when pen drive is attached.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jul 2012 10:24:32 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb/host/ehci-hub: Fix the issue EG20T USB host controller
 has long resuming time, when pen drive is attached.

On Wed, 11 Jul 2012, Tomoya MORINAGA wrote:

> 
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>

There's no patch description.  What is the cause of the problem and how
does the patch fix it?

> ---
>  drivers/usb/host/ehci-hub.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index fc9e7cc..d596d0f 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> @@ -207,6 +207,7 @@ static int ehci_bus_suspend (struct usb_hcd *hcd)
>  	int			port;
>  	int			mask;
>  	int			changed;
> +	int			temp;
>  
>  	ehci_dbg(ehci, "suspend root hub\n");
>  
> @@ -324,6 +325,9 @@ static int ehci_bus_suspend (struct usb_hcd *hcd)
>  	 * want, and so we must delete any pending watchdog timer events.
>  	 */
>  	del_timer_sync(&ehci->watchdog);
> +	temp = ehci_readl(ehci, &ehci->regs->status);
> +	if (temp & STS_FLR)
> +		ehci_writel(ehci, STS_FLR, &ehci->regs->status);
>  	return 0;

Operations like this should be done while holding the spinlock.

Also, why do you need the ehci_readl and the test?  You could always 
clear the STS_FLR flag.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/