linux-kernel - Re: [PATCH v2] panel: Use pr_err(...) rather than printk(KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1342019603.13724.65.camel@joe2Laptop>
Date:	Wed, 11 Jul 2012 08:13:23 -0700
From:	Joe Perches <joe@...ches.com>
To:	Toshiaki Yamane <yamanetoshi@...il.com>
Cc:	greg@...ah.com, willy@...a-x.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] panel: Use pr_err(...) rather than printk(KERN_ERR
 ...)

On Wed, 2012-07-11 at 17:59 +0900, Toshiaki Yamane wrote:
> This change is inspired by checkpatch.

The changelog could be improved a bit.  Maybe:

Added pr_fmt.
Removed unnecessary OOM messages.
Removed embedded message prefixes.
Added __func__ to all pr_err messages.

> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
[]
> @@ -2110,10 +2110,8 @@ static void panel_attach(struct parport *port)
>  		return;
>  
>  	if (pprt) {
> -		printk(KERN_ERR
> -		       "panel_attach(): port->number=%d parport=%d, "
> -		       "already registered !\n",
> -		       port->number, parport);
> +		pr_err("%s: port->number=%d parport=%d, already registerd !\n",
> +		       __func__, port->number, parport);

typo of registered


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/