linux-kernel - Re: [PATCH] Smack: don't show empty rules when /smack/load or /smack/load2 is read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FFD99C0.5090200@schaufler-ca.com>
Date:	Wed, 11 Jul 2012 08:20:32 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Rafal Krypa <r.krypa@...sung.com>
CC:	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH] Smack: don't show empty rules when /smack/load or /smack/load2
 is read

On 7/9/2012 10:36 AM, Rafal Krypa wrote:
> This patch removes empty rules (i.e. with access set to '-') from the
> rule list presented to user space.
>
> Smack by design never removes labels nor rules from its lists. Access
> for a rule may be set to '-' to effectively disable it. Such rules would
> show up in the listing generated when /smack/load or /smack/load2 is
> read. This may cause clutter if many rules were disabled.
>
> As a rule with access set to '-' is equivalent to no rule at all, they
> may be safely hidden from the listing.
>
> Targeted for git://git.gitorious.org/smack-next/kernel.git

Applied to git://git.gitorious.org/smack-next/kernel.git

>
> Signed-off-by: Rafal Krypa <r.krypa@...sung.com>
> ---
>  security/smack/smackfs.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 29b760d..d31e6d9 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -518,6 +518,9 @@ static void smk_rule_show(struct seq_file *s, struct smack_rule *srp, int max)
>  	if (strlen(srp->smk_subject) >= max || strlen(srp->smk_object) >= max)
>  		return;
>  
> +	if (srp->smk_access == 0)
> +		return;
> +
>  	seq_printf(s, "%s %s", srp->smk_subject, srp->smk_object);
>  
>  	seq_putc(s, ' ');
> @@ -532,8 +535,6 @@ static void smk_rule_show(struct seq_file *s, struct smack_rule *srp, int max)
>  		seq_putc(s, 'a');
>  	if (srp->smk_access & MAY_TRANSMUTE)
>  		seq_putc(s, 't');
> -	if (srp->smk_access == 0)
> -		seq_putc(s, '-');
>  
>  	seq_putc(s, '\n');
>  }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/