linux-kernel - Re: [PATCH v4] virtio-scsi: hotplug support for virtio-scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342031676.3522.39.camel@dabdike.int.hansenpartnership.com>
Date:	Wed, 11 Jul 2012 19:34:36 +0100
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Cong Meng <mc@...ux.vnet.ibm.com>, stefanha@...ux.vnet.ibm.com,
	linuxram@...ibm.com, senwang@...ux.vnet.ibm.com, zwanp@...ibm.com,
	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH v4] virtio-scsi: hotplug support for virtio-scsi

On Thu, 2012-07-05 at 11:19 +0200, Paolo Bonzini wrote:
> Il 05/07/2012 11:06, Cong Meng ha scritto:
> > This patch implements the hotplug support for virtio-scsi.
> > When there is a device attached/detached, the virtio-scsi driver will be
> > signaled via event virtual queue and it will add/remove the scsi device 
> > in question automatically.
> > 
> > v2: handle no_event event
> > v3: add handle event dropped, and typo fix
> > v4: Cancel event works when exit. Coding type fix.
> > 
> > Signed-off-by: Sen Wang <senwang@...ux.vnet.ibm.com>
> > Signed-off-by: Cong Meng <mc@...ux.vnet.ibm.com>
> 
> Reviewed-by: Paolo Bonzini <pbonzini@...hat.com>

Actually, that should be Acked-by, since you're the maintainer of the
driver (it means I reviewed it + I approve it for upstream inclusion).

> > ---
> >  drivers/scsi/virtio_scsi.c  |  127 ++++++++++++++++++++++++++++++++++++++++++-
> >  include/linux/virtio_scsi.h |    9 +++
> >  2 files changed, 135 insertions(+), 1 deletions(-)

The next time, please run checkpatch on this.  You can ignore the
warnings about lines over 80 characters, but the braces issue is worth
paying attention to when that reflects the current style.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/