linux-kernel - Re: [PATCHv2 1/4] staging: OMAP4+: thermal: introduce bandgap temperature sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGF5oy_sd8MHJdj+vHhGnqJDz1W9AAzvuuzQLmsLS8TjKJUunA@mail.gmail.com>
Date:	Wed, 11 Jul 2012 23:45:47 +0300
From:	"Valentin, Eduardo" <eduardo.valentin@...com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, b-cousson@...com, j-keerthy@...com,
	linux-kernel@...r.kernel.org, kbaidarov@....rtsoft.ru,
	grant.likely@...retlab.ca
Subject: Re: [PATCHv2 1/4] staging: OMAP4+: thermal: introduce bandgap
 temperature sensor

Greg,

On Wed, Jul 11, 2012 at 11:07 PM, Valentin, Eduardo
<eduardo.valentin@...com> wrote:
> Greg,
>
> On Wed, Jul 11, 2012 at 3:52 PM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>> On Wed, Jul 11, 2012 at 01:07:17PM +0300, Valentin, Eduardo wrote:
>>> Hello Greg,
>>>
>>> On Mon, Jul 9, 2012 at 11:33 PM, Valentin, Eduardo
>>> <eduardo.valentin@...com> wrote:
>>> > Hello Greg,
>>> >
>>> > On Mon, Jul 9, 2012 at 10:31 PM, Greg Kroah-Hartman
>>> > g<gregkh@...uxfoundation.org> wrote:
>>> >> On Sat, Jul 07, 2012 at 10:57:49AM +0300, Eduardo Valentin wrote:
>>> >>> In the System Control Module, OMAP supplies a voltage reference
>>> >>> and a temperature sensor feature that are gathered in the band
>>> >>> gap voltage and temperature sensor (VBGAPTS) module. The band
>>> >>> gap provides current and voltage reference for its internal
>>> >>> circuits and other analog IP blocks. The analog-to-digital
>>> >>> converter (ADC) produces an output value that is proportional
>>> >>> to the silicon temperature.
>>> >>>
>>> >>> This patch provides a platform driver which expose this feature.
>>> >>> It is moduled as a MFD child of the System Control Module core
>>> >>> MFD driver.
>>> >>>
>>> >>> This driver provides only APIs to access the device properties,
>>> >>> like temperature, thresholds and update rate.
>>> >>>
>>> >>> Signed-off-by: Eduardo Valentin <eduardo.valentin@...com>
>>> >>> Signed-off-by: Keerthy <j-keerthy@...com>
>>> >>
>>> >> As much as I enjoy interesting names, odds are, "Keerthy" is not the
>>> >> real name of this person, right?  In fact, based on the copyright
>>> >> comments in the code, I can almost guarantee it...
>>> >>
>>> >> I need a full-name please, no aliases or fake names allowed in kernel
>>> >> signed-off-by lines.
>>> >>
>>> >> Please resend these with that fixed up.
>>> >
>>> > Actually, his name is in fact Keerthy J.  I can resend with the
>>> > additional "J" the way it is in the copyrights.
>>>
>>> While looking into his commits, I believe the SOB in this patch is one
>>> of the ways he uses to sign:
>>> commit f99c1d4f94f91fd3a20bd2eaa3be9c5e7d2668eb
>>> Author: Keerthy <j-keerthy@...com>
>>> Date:   Tue Mar 1 19:12:26 2011 +0530
>>>
>>>     mfd: Add twl4030 madc driver
>>>
>>>     Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring
>>>     ADC. This driver monitors the real time conversion of analog signals like
>>>     battery temperature, battery cuurent etc.
>>>
>>>     Signed-off-by: Keerthy <j-keerthy@...com>
>>>     Signed-off-by: Samuel Ortiz <sameo@...ux.intel.com>
>>>
>>> So, I'd prefer to keep the way it is.
>>
>> But it doesn't match the copyright notice, which I am guessing TI got
>> "right" from a legal perspective, and as such, we need to also.
>>
>
> Now I see your point, it makes sense. Resending V3 of this patch in
> reply on this thread. It will contain his SOB the way it is in the
> copyright notice.

FYI, I've just resent the 4 patches in this series with v3 mark,
because I removed one ending empty line added in patch 01 as git was
complaining while applying and had to adapt following patch 02. Now
patch 01 has his SOB just like in the copyright notice in the files.


>
>> thanks,
>>
>> greg k-h
>
>
>
> --
>
> Eduardo Valentin



-- 

Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/