linux-kernel - [PATCH 1/1] eCryptfs: check for eCryptfs cipher support at mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Jul 2012 21:05:51 -0400
From:	Tim Sally <tsally@...micpeace.com>
To:	tyhicks@...onical.com, dustin.kirkland@...zang.com
Cc:	ecryptfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tim Sally <tsally@...micpeace.com>
Subject: [PATCH 1/1] eCryptfs: check for eCryptfs cipher support at mount

The issue occurs when eCryptfs is mounted with a cipher supported by
the crypto subsystem but not by eCryptfs. The mount succeeds and an
error does not occur until a write. This change checks for eCryptfs
cipher support at mount time.

Resolves Launchpad issue #338914, reported by Tyler Hicks in 03/2009.
https://bugs.launchpad.net/ecryptfs/+bug/338914

Signed-off-by: Tim Sally <tsally@...micpeace.com>
---
 fs/ecryptfs/main.c |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
index df217dc..4eb1fc6 100644
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -279,6 +279,8 @@ static int ecryptfs_parse_options(struct ecryptfs_sb_info *sbi, char *options,
 	char *fnek_src;
 	char *cipher_key_bytes_src;
 	char *fn_cipher_key_bytes_src;
+	struct ecryptfs_key_tfm *key_tfm = NULL;
+	u8 cipher_code;
 
 	*check_ruid = 0;
 
@@ -456,6 +458,28 @@ static int ecryptfs_parse_options(struct ecryptfs_sb_info *sbi, char *options,
 			goto out;
 		}
 	}
+
+	if (!ecryptfs_tfm_exists(mount_crypt_stat->global_default_cipher_name,
+					&key_tfm)) {
+		ecryptfs_printk(KERN_ERR,
+				"Cipher %s was not initalized correctly.\n",
+				mount_crypt_stat->global_default_cipher_name);
+		rc = -EINVAL;
+		mutex_unlock(&key_tfm_list_mutex);
+		goto out;
+	}
+
+	cipher_code = ecryptfs_code_for_cipher_string(key_tfm->cipher_name,
+						key_tfm->key_size);
+	if (!cipher_code) {
+		ecryptfs_printk(KERN_ERR,
+				"eCryptfs doesn't support: %s blocksize %zu.\n",
+				key_tfm->cipher_name, key_tfm->key_size);
+		rc = -EINVAL;
+		mutex_unlock(&key_tfm_list_mutex);
+		goto out;
+	}
+
 	mutex_unlock(&key_tfm_list_mutex);
 	rc = ecryptfs_init_global_auth_toks(mount_crypt_stat);
 	if (rc)
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/