linux-kernel - Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FFE92A6.2070106@mev.co.uk>
Date:	Thu, 12 Jul 2012 10:02:30 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Ian Abbott <ian.abbott@....co.uk>,
	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

On 2012/07/12 10:02 AM, Alan Cox wrote:
>> I suppose at a later date we could turn that into a union with a short
>> name like u (so comedidev->pcidev would become something like
>> comedidev->u.pcidev), which would allow us to stick a 'struct
>> usb_interface *' or some other hardware device wrapper struct pointer in
>> the same hole.  (Maybe 'h' for 'hardware' would be better than 'u'.)
> 
> The "usual" pattern is to make it a struct device pointer. Then you can
> get to any other kind of device from it.

You mean with container_of(), right?  Actually, 'struct comedi_device'
already has a little-used 'struct device *hw_dev' member that could be
used for this purpose.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>             )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587              )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/