linux-kernel - Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120712011038.GB6971@S2101-09.ap.freescale.net>
Date:	Thu, 12 Jul 2012 09:10:40 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <kernel@...gutronix.de>,
	Philippe Rétornaz <philippe.retornaz@...l.ch>,
	Marc Reilly <marc@...esign.com.au>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's
 id_table in probe

On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote:
> This was introduced in commit
> 
> 	876989d (mfd: Add device tree probe support for mc13xxx)
> 
> for spi and later while introducing support for i2c copied to the i2c
> driver.
> 
> Modifying driver details is very strange, for example probing an
> mc13892 device (instantiated via dt) removes the driver's ability to
> handle (traditionally probed) mc13783 devices in this case.
> I'm not aware of any problems that make this hack necessary and if
> there were some, they'd have to be fixed in the spi/i2c core, not in
> a driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

The code was added by me, and it turns out the change is completely
unnecessary.  So,

Acked-by: Shawn Guo <shawn.guo@...aro.org>

Regards,
Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/