linux-kernel - Re: [PATCH V3 1/2] driver: add PPI support in tpm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120712144529.GA32640@linux.vnet.ibm.com>
Date:	Thu, 12 Jul 2012 09:45:29 -0500
From:	Kent Yoder <key@...ux.vnet.ibm.com>
To:	"Zhang, Xiaoyan" <xiaoyan.zhang@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Cihula, Joseph" <joseph.cihula@...el.com>,
	"Wei, Gang" <gang.wei@...el.com>,
	"tpmdd-devel@...ts.sourceforge.net" 
	<tpmdd-devel@...ts.sourceforge.net>,
	"debora@...ux.vnet.ibm.com" <debora@...ux.vnet.ibm.com>,
	"srajiv@...ux.vnet.ibm.com" <srajiv@...ux.vnet.ibm.com>,
	"m.selhorst@...rix.com" <m.selhorst@...rix.com>,
	"shpedoikal@...il.com" <shpedoikal@...il.com>,
	"linux-security-module@...r.kernel.org" 
	<linux-security-module@...r.kernel.org>,
	"james.l.morris@...cle.com" <james.l.morris@...cle.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>
Subject: Re: [PATCH V3 1/2] driver: add PPI support in tpm driver

On Thu, Jul 12, 2012 at 02:38:56AM +0000, Zhang, Xiaoyan wrote:
> Hi Kent,
> 
> Thanks for your comment on the patch. But there's some confusion on my side.
> You mentioned not to change the tpm driver name. But the driver is linked from tpm.c and tpm_ppi.c, so I should change the original tpm.c file name, right? Is it acceptable to change tpm.c to tpm_common.c or tpm_utils.c or else?

  I think you can just add tpm_ppi.c like this:

diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
index beac52f6..96b9222 100644
--- a/drivers/char/tpm/Makefile
+++ b/drivers/char/tpm/Makefile
@@ -4,7 +4,7 @@
 obj-$(CONFIG_TCG_TPM) += tpm.o
 ifdef CONFIG_ACPI
        obj-$(CONFIG_TCG_TPM) += tpm_bios.o
-       tpm_bios-objs += tpm_eventlog.o tpm_acpi.o
+       tpm_bios-objs += tpm_eventlog.o tpm_acpi.o tpm_ppi.o
 endif
 obj-$(CONFIG_TCG_TIS) += tpm_tis.o
 obj-$(CONFIG_TCG_TIS_I2C_INFINEON) += tpm_i2c_infineon.o

Kent

> 
> Thanks,
> Xiaoyan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/