| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Jul 2012 07:30:09 +0900 From: Sangbeom Kim <sbkim73@...sung.com> To: 'Venu Byravarasu' <vbyravarasu@...dia.com>, sameo@...ux.intel.com, 'Mark Brown' <broonie@...nsource.wolfsonmicro.com> Cc: 'Liam Girdwood' <lrg@...com>, linux-kernel@...r.kernel.org, sbkim01@...il.com Subject: RE: [PATCH V3 3/7] mfd: samsung: Modify samsung mfd header Hi! On Wednesday, July 11, 2012 9:30 PM, Venu Byravarasu wrote: > > + * copyright (c) 2011 Samsung Electronics Co., Ltd > > + * http://www.samsung.com > > In most of the files you mentioned 2011. > Should they not be changed to 2012? Most of the files are created in 2011. This file is moved from include/linux/mfd/s5m87xx/s5m-core.h > > - int buck_set1; > > - int buck_set2; > > - int buck_set3; > > As you have buck4_enable etc below, by any chance do you need buck_set4 as well here? No, S5M8767 have 3 controllerble gpios. The purpose of buck_set1,2,3 is each gpio control. To handle 3 gpio, I had added buck_set1, buck_set2, buck_set3. > Similarly should you declare buck1_enable here? No, gpio control can be enabled on buck2, buck3, buck4. There is no need buck1_enable. > > - int buck2_enable; > > - int buck3_enable; > > - int buck4_enable; > > - int buck_default_idx; > > - int buck2_default_idx; Thanks, Sangbeom. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists