linux-kernel - Re: [PATCH v3] panel: Use pr_err(...) rather than printk(KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342071788.1970.18.camel@joe2Laptop>
Date:	Wed, 11 Jul 2012 22:43:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ryan Mallon <rmallon@...il.com>
Cc:	Toshiaki Yamane <yamanetoshi@...il.com>, greg@...ah.com,
	willy@...a-x.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] panel: Use pr_err(...) rather than printk(KERN_ERR
 ...)

On Thu, 2012-07-12 at 15:22 +1000, Ryan Mallon wrote:
> On 12/07/12 12:35, Toshiaki Yamane wrote:
> > This change is inspired by checkpatch.
> 
> Your changelog needs to describe all of the changes you are making. The
> subject line only describes one. This patch is doing the following:
> 
>  - Converting printk(KERN_ERR to pr_err
>  - Adding __func__ prefixes to printk lines
>  - Refactoring split printk strings onto a single line
> 
> There are a few other printks in this file which could be converted to
> pr_* to make the code more consistent. Perhaps a follow up patch?
> 
> Typically for a sub-sequent version of a patch/series you should list
> the changes since the last round. Put these below the --- so that they
> don't become part of the change log, e.g.:
> 
>   Signed-off-by: Your name/email here
>   ---
> 
>   Changes since v2:
>     - Some stuff
> 
>   Changes since v1:
>     - Some other stuff
> 
> Some more comments below.

And ideally cc the people that gave you notes/comments
on your previous patches too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/