linux-kernel - Re: [PATCH 2/2] mtd: lpc32xx_mlc: Adjust to pl08x DMA interface changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAAP30GxeXHfeZZchYzSjBQXfkS+o+sabAU5iy8uBxiSoO87hQ@mail.gmail.com>
Date:	Fri, 13 Jul 2012 09:51:29 -0300
From:	Alexandre Pereira da Silva <aletes.xgr@...il.com>
To:	Roland Stigge <stigge@...com.de>
Cc:	linux-arm-kernel@...ts.infradead.org, arnd@...db.de,
	linux@....linux.org.uk, linux-kernel@...r.kernel.org,
	kevin.wells@....com, srinivas.bakki@....com, dwmw2@...radead.org,
	artem.bityutskiy@...ux.intel.com, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 2/2] mtd: lpc32xx_mlc: Adjust to pl08x DMA interface changes

On Thu, Jul 12, 2012 at 9:22 AM, Roland Stigge <stigge@...com.de> wrote:
> This patch adjusts the LPC32xx MLC NAND driver to the new pl08x DMA interface,
> fixing the compile error resulting from changed pl08x structures.
>
> Signed-off-by: Roland Stigge <stigge@...com.de>

Acked-By: Alexandre Pereira da Silva <aletes.xgr@...il.com>

> ---
>
> Applies to today's linux-next (integrated lpc32xx-next and dma branches which collide)
>
>  drivers/mtd/nand/lpc32xx_mlc.c |   13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
> index 260b2c2..1cf3593 100644
> --- a/drivers/mtd/nand/lpc32xx_mlc.c
> +++ b/drivers/mtd/nand/lpc32xx_mlc.c
> @@ -576,17 +576,6 @@ static void lpc32xx_ecc_enable(struct mtd_info *mtd, int mode)
>         /* Always enabled! */
>  }
>
> -static bool lpc32xx_dma_filter(struct dma_chan *chan, void *param)
> -{
> -       struct pl08x_dma_chan *ch =
> -               container_of(chan, struct pl08x_dma_chan, chan);
> -
> -       /* In LPC32xx's PL080 DMA wiring, the MLC NAND DMA signal is #12 */
> -       if (ch->cd->min_signal == 12)
> -               return true;
> -       return false;
> -}
> -
>  static int lpc32xx_dma_setup(struct lpc32xx_nand_host *host)
>  {
>         struct mtd_info *mtd = &host->mtd;
> @@ -594,7 +583,7 @@ static int lpc32xx_dma_setup(struct lpc32xx_nand_host *host)
>
>         dma_cap_zero(mask);
>         dma_cap_set(DMA_SLAVE, mask);
> -       host->dma_chan = dma_request_channel(mask, lpc32xx_dma_filter, NULL);
> +       host->dma_chan = dma_request_channel(mask, pl08x_filter_id, "nand-mlc");
>         if (!host->dma_chan) {
>                 dev_err(mtd->dev.parent, "Failed to request DMA channel\n");
>                 return -EBUSY;
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/