linux-kernel - Re: [PATCH v2] Extend core dump note section to contain file names of mapped files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120713145806.GA17217@redhat.com>
Date:	Fri, 13 Jul 2012 16:58:06 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Denys Vlasenko <vda.linux@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	"Jonathan M. Foote" <jmfoote@...t.org>,
	"H. J. Lu" <hjl.tools@...il.com>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Jan Kratochvil <jan.kratochvil@...hat.com>
Subject: Re: [PATCH v2] Extend core dump note section to contain file names
	of mapped files

On 07/12, Denys Vlasenko wrote:
>
> This note has the following format:
>
> long count     -- how many files are mapped
> long page_size -- units for file_ofs
> array of [COUNT] elements of
>    long start
>    long end
>    long file_ofs
> followed by COUNT filenames in ASCII: "FILE1" NUL "FILE2" NUL...

All I can say, I believe the patch is correct.

Only one nit... Afaics, fill_files_note() has no callers without
CORE_DUMP_USE_REGSET, so perhaps you should either move it under
ifdef (to avoid the warning) or modify the !CORE_DUMP_USE_REGSET
code to use NT_FILE as well.


Otherwise I can't comment the patch, I simply do not know what
people do with the coredumps. But Denys certainly knows, he works
with the tools which need this info.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/