linux-kernel - Re: [PATCH RFC] regulator: mc13xxx: Populate selector from mc13xxx_fixed_regulator_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120713163448.GQ4215@opensource.wolfsonmicro.com>
Date:	Fri, 13 Jul 2012 17:34:48 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	Yong Shen <yong.shen@...aro.org>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] regulator: mc13xxx: Populate selector from
 mc13xxx_fixed_regulator_set_voltage

On Fri, Jul 13, 2012 at 11:01:14PM +0800, Axel Lin wrote:

> Not very sure if we should implement set_voltage callback for fixed voltage.
> ( Other drivers do not implement set_voltage callback for fixed voltage.
> Since the voltage is fixed, implement set_voltage callback seems does not make sense.)

We shouldn't normally implement it.  The fixed voltage driver does so
because it reuses the existing set voltage device tree binding to
specify the voltage it provides but I'd not expect other drivers to need
to do this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)