linux-kernel - Re: Remove easily user-triggerable BUG from generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyg7Cs5KF4HGQKAUi29+RpXJdUyEm6uy57rwVBB_jyN3Q@mail.gmail.com>
Date:	Fri, 13 Jul 2012 10:47:43 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"J. Bruce Fields" <bfields@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: Remove easily user-triggerable BUG from generic_setlease

On Fri, Jul 13, 2012 at 10:35 AM, Dave Jones <davej@...hat.com> wrote:
> This can be trivially triggered from userspace by passing in something unexpected.

Argh. It looks like it would be harmless (apart from the noise),
except we hold file_lock_lock. Which turns the BUG_ON() into not just
"noise and kill the process", but "noise and kill the process and
leave a nasty lock held".

This seems to go back to 3.2, so stable should be cc'd, no?

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/