linux-kernel - Re: [PATCH] pps: Return PTR_ERR on error in device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHdPZaNQ50Y33Ap7_-9a-brQnOmxOy49GMjYnhHBxeNHjCjgOQ@mail.gmail.com>
Date:	Sat, 14 Jul 2012 12:58:45 +0545
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Emil Goode <emilgoode@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Gordeev <lasaine@....cs.msu.su>,
	giometti@...eenne.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] pps: Return PTR_ERR on error in device_create

CCing Andrew Morton, and Alexander Gordeev based on git log drivers/pps/pps.c
Pardon me if i made wrong

On Sat, Jun 2, 2012 at 1:28 AM, Emil Goode <emilgoode@...il.com> wrote:
> We should return PTR_ERR if the call to the
> device_create function fails.
> Without this patch we instead return the value
> from a successful call to cdev_add if the call
> to device_create fails.
>
> Signed-off-by: Emil Goode <emilgoode@...il.com>
> ---
>  drivers/pps/pps.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c
> index 98fbe62..e771487 100644
> --- a/drivers/pps/pps.c
> +++ b/drivers/pps/pps.c
> @@ -327,8 +327,10 @@ int pps_register_cdev(struct pps_device *pps)
>         }
>         pps->dev = device_create(pps_class, pps->info.dev, devt, pps,
>                                                         "pps%d", pps->id);
> -       if (IS_ERR(pps->dev))
> +       if (IS_ERR(pps->dev)) {
> +               err = PTR_ERR(pps->dev);
>                 goto del_cdev;
> +       }
>
>         pps->dev->release = pps_device_destruct;
>
> --
> 1.7.10
>
Acked-By: Devendra Naga <devendra.aaru@...il.com>

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/