linux-kernel - Re: [PATCH 3/3] x86/mm: Separate paging setup from memory mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOJsxLG7KSJzr-Tb=27jAsBNF1c3Vnedcebpp0kn+XSagXhHZw@mail.gmail.com>
Date:	Sun, 15 Jul 2012 14:02:55 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	mingo@...nel.org, linux-kernel@...r.kernel.org, x86@...nel.org,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 3/3] x86/mm: Separate paging setup from memory mapping

On Sat, Jul 14, 2012 at 6:41 AM, Pekka Enberg <penberg@...nel.org> wrote:
>> Move PSE and PGE bit twiddling from init_memory_mapping() to a new
>> setup_paging() function to simplify the former function. The
>> init_memory_mapping() function is called later in the boot process by
>> gart_iommu_init(), efi_ioremap(), and arch_add_memory() which have no
>> business whatsover updating the CR4 register.

On Sat, Jul 14, 2012 at 11:47 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> I have one local patch that will only set that one time too. also do
> other page size probe one time.
>
> please check attached one.

Your patch still keeps the same sort of code flow. That is,
init_memory_mapping() does all sorts of things upon first call. I
personally prefer the more explicit approach in this patch. In fact,
you could do the page_size_mask setup in the setup_paging() function.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/