linux-kernel - Re: [PATCH] Checkpatch fixes for drivers/staging/panel/panel.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvyKjJkRbjBbReowwM5Ljf+Vs9XcaNEMhA00rJQgwrFQYw@mail.gmail.com>
Date:	Sun, 15 Jul 2012 17:35:49 +0200
From:	richard -rw- weinberger <richard.weinberger@...il.com>
To:	Cruz Julian Bishop <cruz@...sive-dynamics.biz>
Cc:	greg@...ah.com, willy@...a-x.org, linux-kernel@...r.kernel.org,
	Cruz Julian Bishop <cruzjbishop@...il.com>
Subject: Re: [PATCH] Checkpatch fixes for drivers/staging/panel/panel.c

On Sun, Jul 15, 2012 at 2:44 PM, Cruz Julian Bishop
<cruz@...sive-dynamics.biz> wrote:
>  #if 0
> -       printk(KERN_DEBUG
> -              "entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
> +       pr_debug("entering panel_process_inputs with pp=%016Lx & pc=%016Lx\n",
>                phys_prev, phys_curr);
>  #endif

Instead of following checkpatch.pl's suggestions in a completely
brain-dead manner you should better read the code.
The printk() is under a "#if 0", so the whole block is useless anyway...

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/