linux-kernel - Re: [PATCH] staging/cptm1217: fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfyv35EGx=sFMTdzkwZNw0TLwEf7to_QLkveWf_JZSZMTricA@mail.gmail.com>
Date:	Mon, 16 Jul 2012 10:15:02 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	Toshiaki Yamane <yamanetoshi@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/cptm1217: fix checkpatch warnings

On Mon, Jul 16, 2012 at 10:12 AM, Toshiaki Yamane <yamanetoshi@...il.com> wrote:
> The below checkpatch warns was fixed,
>
> drivers/staging/cptm1217/clearpad_tm1217.c:400: WARNING: quoted string split across lines
> drivers/staging/cptm1217/cp_tm1217.h:5: ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@...il.com>
> ---
>  drivers/staging/cptm1217/clearpad_tm1217.c |    4 ++--
>  drivers/staging/cptm1217/cp_tm1217.h       |    3 +--
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/cptm1217/clearpad_tm1217.c b/drivers/staging/cptm1217/clearpad_tm1217.c
> index 5456f82..59e7e87 100644
> --- a/drivers/staging/cptm1217/clearpad_tm1217.c
> +++ b/drivers/staging/cptm1217/clearpad_tm1217.c
> @@ -396,8 +396,8 @@ static int cp_tm1217_setup_gpio_irq(struct cp_tm1217_device *ts)
>
>         retval = gpio_to_irq(ts->gpio);
>         if (retval < 0) {
> -               dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failedi,"
> -               " error %d\n", retval);
> +               dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failedi, error %d\n",
there is also typo (you can fix that as well)                           ^^^^
> +                       retval);
>                 gpio_free(ts->gpio);
>         }
>         dev_dbg(ts->dev,
> diff --git a/drivers/staging/cptm1217/cp_tm1217.h b/drivers/staging/cptm1217/cp_tm1217.h
> index a0ce31d..30bad35 100644
> --- a/drivers/staging/cptm1217/cp_tm1217.h
> +++ b/drivers/staging/cptm1217/cp_tm1217.h
> @@ -1,8 +1,7 @@
>  #ifndef __LINUX_I2C_CP_TM1217_H
>  #define __LINUX_I2C_CP_TM1217_H
>
> -struct cp_tm1217_platform_data
> -{
> +struct cp_tm1217_platform_data {
>         int gpio;               /* If not set uses the IRQ resource 0 */
>  };
>
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/