linux-kernel - Re: [PATCH net-next 7/8] usb: Use eth_random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120716111556.GB4913@arwen.pp.htv.fi>
Date:	Mon, 16 Jul 2012 14:15:57 +0300
From:	Felipe Balbi <balbi@...com>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>, Felipe Balbi <balbi@...com>,
	Johannes Berg <johannes@...solutions.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 7/8] usb: Use eth_random_addr

On Thu, Jul 12, 2012 at 10:33:11PM -0700, Joe Perches wrote:
> Convert the existing uses of random_ether_addr to
> the new eth_random_addr.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

for drivers/usb/gadget:

Acked-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/usb/atm/xusbatm.c    |    4 ++--
>  drivers/usb/gadget/u_ether.c |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/atm/xusbatm.c b/drivers/usb/atm/xusbatm.c
> index 14ec9f0..b3b1bb7 100644
> --- a/drivers/usb/atm/xusbatm.c
> +++ b/drivers/usb/atm/xusbatm.c
> @@ -20,7 +20,7 @@
>   ******************************************************************************/
>  
>  #include <linux/module.h>
> -#include <linux/etherdevice.h>		/* for random_ether_addr() */
> +#include <linux/etherdevice.h>		/* for eth_random_addr() */
>  
>  #include "usbatm.h"
>  
> @@ -163,7 +163,7 @@ static int xusbatm_atm_start(struct usbatm_data *usbatm,
>  	atm_dbg(usbatm, "%s entered\n", __func__);
>  
>  	/* use random MAC as we've no way to get it from the device */
> -	random_ether_addr(atm_dev->esi);
> +	eth_random_addr(atm_dev->esi);
>  
>  	return 0;
>  }
> diff --git a/drivers/usb/gadget/u_ether.c b/drivers/usb/gadget/u_ether.c
> index 47cf48b..b9e1925 100644
> --- a/drivers/usb/gadget/u_ether.c
> +++ b/drivers/usb/gadget/u_ether.c
> @@ -724,7 +724,7 @@ static int get_ether_addr(const char *str, u8 *dev_addr)
>  		if (is_valid_ether_addr(dev_addr))
>  			return 0;
>  	}
> -	random_ether_addr(dev_addr);
> +	eth_random_addr(dev_addr);
>  	return 1;
>  }
>  
> -- 
> 1.7.8.111.gad25c.dirty
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)