linux-kernel - Re: [PATCH 1/3] mm: correct return value of migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAmzW4OS7=xfm0shxsi0k8kJ=2oNs4MQAEJ=EJv_xRydrukF1w@mail.gmail.com>
Date:	Tue, 17 Jul 2012 02:57:14 +0900
From:	JoonSoo Kim <js1304@...il.com>
To:	Michal Nazarewicz <mina86@...n.pl>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Christoph Lameter <cl@...ux.com>
Subject: Re: [PATCH 1/3] mm: correct return value of migrate_pages()

2012/7/17 Michal Nazarewicz <mina86@...n.pl>:
> Acked-by: Michal Nazarewicz <mina86@...a86.com>

Thanks.

> Actually, it makes me wonder if there is any code that uses this
> information.  If not, it would be best in my opinion to make it return
> zero or negative error code, but that would have to be checked.

I think that, too.
I looked at every callsites for migrate_pages() and there is no place
which really need fail count.
This function sometimes makes caller error-prone,
so I think changing return value is preferable.

How do you think, Christoph?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/