linux-kernel - Re: [PATCH V2 1/6] mfd: tps6586x:use devm managed resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120716200110.GD10774@opensource.wolfsonmicro.com>
Date:	Mon, 16 Jul 2012 21:01:11 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	grant.likely@...retlab.ca, linus.walleij@...ricsson.com,
	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	swarren@...dia.com
Subject: Re: [PATCH V2 1/6] mfd: tps6586x:use devm managed resources

On Mon, Jul 16, 2012 at 12:21:45PM +0530, Laxman Dewangan wrote:

> -	ret = request_threaded_irq(irq, NULL, tps6586x_irq, IRQF_ONESHOT,
> -				   "tps6586x", tps6586x);
> +	ret = devm_request_threaded_irq(tps6586x->dev, irq, NULL, tps6586x_irq,
> +			IRQF_ONESHOT, "tps6586x", tps6586x);

Are you sure this is safe - what guarantees that we can't get an
interrupt while tearing the device down?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/